Skip to content

confuse missing runtime dependency - #1359

Merged
j-c-c merged 1 commit into
developfrom
confuse_bug
Jan 30, 2026
Merged

confuse missing runtime dependency#1359
j-c-c merged 1 commit into
developfrom
confuse_bug

Conversation

@j-c-c

@j-c-c j-c-c commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pin to confuse==2.1.0 to avoid missing runtime dependency. See issue #1358

@j-c-c j-c-c self-assigned this Jan 29, 2026
@j-c-c j-c-c added bug Something isn't working CI Continuous Integration dependencies Pull requests that update a dependency file labels Jan 29, 2026
@codecov

codecov Bot commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (9bb7667) to head (fcc44b5).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1359   +/-   ##
========================================
  Coverage    90.87%   90.87%           
========================================
  Files          135      135           
  Lines        14672    14672           
========================================
  Hits         13333    13333           
  Misses        1339     1339

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c
j-c-c requested a review from garrettwrong January 29, 2026 18:31
garrettwrong
garrettwrong approved these changes Jan 29, 2026
View reviewed changes

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Did you open an issue with them by chance? They can probably fix it for us upstream if they have not already. Thanks.

@j-c-c

j-c-c commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator Author

Awesome, thanks! Did you open an issue with them by chance? They can probably fix it for us upstream if they have not already. Thanks.

Hey, yes, I opened an issue with them: beetbox/confuse#189

Doesn't look like they've seen it yet.

@j-c-c
j-c-c marked this pull request as ready for review January 29, 2026 19:56
@j-c-c
j-c-c requested a review from janden as a code owner January 29, 2026 19:57
@j-c-c
j-c-c merged commit 7d2d875 into develop Jan 30, 2026
44 checks passed
@garrettwrong

garrettwrong commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Hey, let's merge this one. We can easily revisit if any concerns or issues.

@garrettwrong

garrettwrong commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

oh, you just beat me, hahaha. Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettwrong garrettwrong garrettwrong approved these changes
@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@j-c-c j-c-c

Labels

bug Something isn't working CI Continuous Integration dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j-c-c @garrettwrong